[llvm] [llvm-objdump] Add inlined function display support (PR #142246)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 6 17:10:00 PDT 2025
gulfemsavrun wrote:
Thanks for all the feedback @jh7370!
> This deserves a release note, I think, including highlighting the renamed indent option.
I added this into the release notes.
> Also, I think it would be useful to have a test showing the interaction between the variable and inlined function options, so how a variable is displayed inside an inlined function when both are enabled.
I extended the case to show how it looks like when `--debug-vars` and `--debug-inlined-functions` options are enabled at the same time.
> On that note, does it even make sense for the two to have different values? E.g. one having unicode and the other ASCII? I wonder if we need to revisit how the option works. I'm not sure what would be the best approach, but perhaps there could be a "format" option and a separate option (or options) to determine what to enable. Alternatively, we just go with it and accept that ASCII + unicode is allowed.
I think we can add a new option like `--debug-format` for the format. It can be shared between `--debug-vars` and `--debug--inlined-funcs` like `--debug-indent` option. What are you thoughts on the `line` format that I added? This was a feature requested by some of our project developers who do not want to look at line-drawing characters.
https://github.com/llvm/llvm-project/pull/142246
More information about the llvm-commits
mailing list