[llvm] [JITLink] [test] Extend preexisting MinGW XFAILs to new tests (PR #142375)
Martin Storsjö via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 6 01:05:06 PDT 2025
mstorsjo wrote:
> I think it's fine to land these, but it'd be good to add a FIXME to reenable them once we add `__main` emulation to ORC?
Luckily, as they're `XFAIL`, it'll be a red failure again if it does start passing without updating the tests. :-) But if you prefer I can add a `FIXME` comment about it there as well - would you prefer that next to the `XFAIL` in the tests, or elsewhere?
> The ORC runtime isn't relevant here, but the RuntimeDyld / JITLink distinction is: These are `llvm-jitlink` tests for the new JIT linker. The pure assembly cases are hand written, so have no reference to `__main`, but the new `.ll` ones are compiled by `llc` which will add a reference -- that's probably what's caused the difference.
Yep; fwiw I noted that `lli` does hook up a dummy `__main` similarly already: https://github.com/llvm/llvm-project/blob/eb71fdde5709b0200b8be343088c763be0850ff6/llvm/tools/lli/lli.cpp#L1083-L1089
https://github.com/llvm/llvm-project/pull/142375
More information about the llvm-commits
mailing list