[clang] [llvm] [AArch64TargetParser]Fix reconstructFromParsedFeatures ignoring negative features (PR #142236)

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 5 15:55:12 PDT 2025


================
@@ -60,7 +60,7 @@ uint64_t AArch64::getFMVPriority(ArrayRef<StringRef> Features) {
   ExtensionSet FeatureBits;
   for (const StringRef Feature : Features) {
     std::optional<FMVInfo> FMV = parseFMVExtension(Feature);
-    if (!FMV) {
+    if (!FMV && Feature.starts_with('+')) {
----------------
MatzeB wrote:

I don't think it's explicitly stated that empty strings are forbidden, so wouldn't like to just make assumptions also as I don't expect this function to performance critical...

https://github.com/llvm/llvm-project/pull/142236


More information about the llvm-commits mailing list