[llvm] [IVDesc] Drop unused arg in isConditionalRdxPattern (NFC) (PR #142942)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 5 03:30:50 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-analysis
Author: Ramkumar Ramachandra (artagnon)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/142942.diff
2 Files Affected:
- (modified) llvm/include/llvm/Analysis/IVDescriptors.h (+1-2)
- (modified) llvm/lib/Analysis/IVDescriptors.cpp (+3-3)
``````````diff
diff --git a/llvm/include/llvm/Analysis/IVDescriptors.h b/llvm/include/llvm/Analysis/IVDescriptors.h
index d12780cde71d7..3b627a5140854 100644
--- a/llvm/include/llvm/Analysis/IVDescriptors.h
+++ b/llvm/include/llvm/Analysis/IVDescriptors.h
@@ -172,8 +172,7 @@ class RecurrenceDescriptor {
/// Returns a struct describing if the instruction is a
/// Select(FCmp(X, Y), (Z = X op PHINode), PHINode) instruction pattern.
- LLVM_ABI static InstDesc isConditionalRdxPattern(RecurKind Kind,
- Instruction *I);
+ LLVM_ABI static InstDesc isConditionalRdxPattern(Instruction *I);
/// Returns the opcode corresponding to the RecurrenceKind.
LLVM_ABI static unsigned getOpcode(RecurKind Kind);
diff --git a/llvm/lib/Analysis/IVDescriptors.cpp b/llvm/lib/Analysis/IVDescriptors.cpp
index d13f2e139ee4a..7232283b9101b 100644
--- a/llvm/lib/Analysis/IVDescriptors.cpp
+++ b/llvm/lib/Analysis/IVDescriptors.cpp
@@ -483,7 +483,7 @@ bool RecurrenceDescriptor::AddReductionVar(
} else if (!isa<PHINode>(UI) &&
((!isa<FCmpInst>(UI) && !isa<ICmpInst>(UI) &&
!isa<SelectInst>(UI)) ||
- (!isConditionalRdxPattern(Kind, UI).isRecurrence() &&
+ (!isConditionalRdxPattern(UI).isRecurrence() &&
!isAnyOfPattern(TheLoop, Phi, UI, IgnoredVal)
.isRecurrence() &&
!isMinMaxPattern(UI, Kind, IgnoredVal).isRecurrence())))
@@ -802,7 +802,7 @@ RecurrenceDescriptor::isMinMaxPattern(Instruction *I, RecurKind Kind,
/// %add = fadd %0, %sum.1
/// %sum.2 = select %cmp, %add, %sum.1
RecurrenceDescriptor::InstDesc
-RecurrenceDescriptor::isConditionalRdxPattern(RecurKind Kind, Instruction *I) {
+RecurrenceDescriptor::isConditionalRdxPattern(Instruction *I) {
SelectInst *SI = dyn_cast<SelectInst>(I);
if (!SI)
return InstDesc(false, I);
@@ -874,7 +874,7 @@ RecurrenceDescriptor::InstDesc RecurrenceDescriptor::isRecurrenceInstr(
case Instruction::Select:
if (Kind == RecurKind::FAdd || Kind == RecurKind::FMul ||
Kind == RecurKind::Add || Kind == RecurKind::Mul)
- return isConditionalRdxPattern(Kind, I);
+ return isConditionalRdxPattern(I);
if (isFindLastIVRecurrenceKind(Kind) && SE)
return isFindLastIVPattern(L, OrigPhi, I, *SE);
[[fallthrough]];
``````````
</details>
https://github.com/llvm/llvm-project/pull/142942
More information about the llvm-commits
mailing list