[llvm] [BOLT] Create marker for source changes in nfc-mode testing. (PR #142931)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 5 02:02:12 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {darker}-->
:warning: Python code formatter, darker found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
darker --check --diff -r HEAD~1...HEAD bolt/utils/nfc-check-setup.py
``````````
</details>
<details>
<summary>
View the diff from darker here.
</summary>
``````````diff
--- nfc-check-setup.py 2025-06-05 08:11:16.000000 +0000
+++ nfc-check-setup.py 2025-06-05 09:01:42.217868 +0000
@@ -5,21 +5,33 @@
import shlex
import subprocess
import sys
import textwrap
+
def get_relevant_bolt_changes(dir: str) -> str:
# Return a list of bolt source changes that are relevant to tests.
all_changes = subprocess.run(
- shlex.split("git show HEAD --name-only --pretty=''"), cwd=dir,
- text=True, stdout=subprocess.PIPE)
+ shlex.split("git show HEAD --name-only --pretty=''"),
+ cwd=dir,
+ text=True,
+ stdout=subprocess.PIPE,
+ )
keep_bolt = subprocess.run(
- shlex.split("grep '^bolt'"), input=all_changes.stdout,
- text=True, stdout=subprocess.PIPE)
+ shlex.split("grep '^bolt'"),
+ input=all_changes.stdout,
+ text=True,
+ stdout=subprocess.PIPE,
+ )
keep_relevant = subprocess.run(
- shlex.split("grep -v -e '^bolt/docs' -e '^bolt/utils/docker' -e '^bolt/utils/dot2html'"),
- input=keep_bolt.stdout, text=True, stdout=subprocess.PIPE)
+ shlex.split(
+ "grep -v -e '^bolt/docs' -e '^bolt/utils/docker' -e '^bolt/utils/dot2html'"
+ ),
+ input=keep_bolt.stdout,
+ text=True,
+ stdout=subprocess.PIPE,
+ )
return keep_relevant.stdout
def get_git_ref_or_rev(dir: str) -> str:
# Run 'git symbolic-ref -q --short HEAD || git rev-parse --short HEAD'
cmd_ref = "git symbolic-ref -q --short HEAD"
@@ -94,11 +106,11 @@
if os.path.exists(marker):
os.remove(marker)
file_changes = get_relevant_bolt_changes(source_dir)
# Create a marker file if any relevant BOLT source files changed.
if len(file_changes) > 0:
- print (f"BOLT source changes were found:\n{file_changes}")
+ print(f"BOLT source changes were found:\n{file_changes}")
open(marker, "a").close()
# determine whether a stash is needed
stash = subprocess.run(
shlex.split("git status --porcelain"),
``````````
</details>
https://github.com/llvm/llvm-project/pull/142931
More information about the llvm-commits
mailing list