[llvm] [HLSL] Adding support for root descriptors in root signature metadata representation (PR #139781)

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 3 09:35:51 PDT 2025


================
@@ -157,6 +222,16 @@ static bool verifyVersion(uint32_t Version) {
   return (Version == 1 || Version == 2);
 }
 
+static bool verifyRegisterValue(uint32_t RegisterValue) {
+  return !(RegisterValue == 0xFFFFFFFF);
+}
+
+static bool verifyRegisterSpace(uint32_t RegisterSpace) {
+  return !(RegisterSpace >= 0xFFFFFFF0 && RegisterSpace <= 0xFFFFFFFF);
----------------
bogner wrote:

Can you add a comment about what the condition we're checking here is? Why are specifically the largest 16 values of a uint32 invalid?

https://github.com/llvm/llvm-project/pull/139781


More information about the llvm-commits mailing list