[llvm] [llvm-exegesis] [AArch64] Resolving "snippet crashed while running: Segmentation fault" for Load Instructions (PR #142552)

via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 3 08:07:14 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- llvm/tools/llvm-exegesis/lib/AArch64/Target.cpp llvm/tools/llvm-exegesis/lib/Assembler.cpp llvm/tools/llvm-exegesis/lib/MCInstrDescView.cpp llvm/tools/llvm-exegesis/lib/MCInstrDescView.h llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp llvm/tools/llvm-exegesis/lib/SnippetGenerator.cpp llvm/tools/llvm-exegesis/lib/Target.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp b/llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp
index 98a5be53c..706c05a1f 100644
--- a/llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp
+++ b/llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp
@@ -136,8 +136,8 @@ static void appendCodeTemplates(const LLVMState &State,
       // TODO: Get a valid scratch memory register,
 
       // Do we need to set scratch memory register based on reg class ?
-      // Or is this code flow even required i.e. would setting register requiring 
-      // memory address from stack correct approach ?
+      // Or is this code flow even required i.e. would setting register
+      // requiring memory address from stack correct approach ?
       if (!RegClass.contains(ScratchMemoryRegister))
         return;
 
diff --git a/llvm/tools/llvm-exegesis/lib/Target.h b/llvm/tools/llvm-exegesis/lib/Target.h
index 736c9d9ff..0304908cb 100644
--- a/llvm/tools/llvm-exegesis/lib/Target.h
+++ b/llvm/tools/llvm-exegesis/lib/Target.h
@@ -308,7 +308,8 @@ public:
     return std::make_unique<SavedState>();
   }
 
-  virtual std::vector<MCInst> _generateRegisterStackPop(MCRegister Reg, int imm = 0) const {
+  virtual std::vector<MCInst> _generateRegisterStackPop(MCRegister Reg,
+                                                        int imm = 0) const {
     return {};
   }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/142552


More information about the llvm-commits mailing list