[llvm] [X86] Stop emitting CFI instructions on i386-windows (PR #135648)

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 3 07:12:21 PDT 2025


================
@@ -1468,7 +1468,9 @@ bool X86FrameLowering::isWin64Prologue(const MachineFunction &MF) const {
 }
 
 bool X86FrameLowering::needsDwarfCFI(const MachineFunction &MF) const {
-  return !isWin64Prologue(MF) && MF.needsFrameMoves();
+  return MF.getTarget().getMCAsmInfo()->getExceptionHandlingType() !=
----------------
rnk wrote:

Effectively this is switching from MCAsmInfo::usesWindowsCFI to getExceptionHandlingType() != Windows.

I think the CFI check seems more logically correct.

I'm OK with the goal, but this code change doesn't seem self-explanatory.

https://github.com/llvm/llvm-project/pull/135648


More information about the llvm-commits mailing list