[llvm] [CoroSplit] Always erase lifetime intrinsics for spilled allocas (PR #142551)

Chuanqi Xu via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 3 00:49:30 PDT 2025


================
@@ -1226,9 +1226,12 @@ static void insertSpills(const FrameDataInfo &FrameData, coro::Shape &Shape) {
     }
 
     // If it is hard to analyze, we will give up and put allocas to frame,
-    // even if they never cross suspend points.
-    // Lifetime intrinsics referring to alloca may fail guard storing to frame.
-    // Lifetime intrinsics referring to frames may block further optimizations.
+    // even if they never cross suspend points.Lifetime intrinsics referring
+    // to alloca may fail guard storing to frame.
----------------
ChuanqiXu9 wrote:

I prefer to remove this. Since it said "if" but it don't judge any thing.

https://github.com/llvm/llvm-project/pull/142551


More information about the llvm-commits mailing list