[llvm] SelectionDAG: Use unique_ptr for SwiftErrorValueTracking (PR #142532)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 2 22:56:57 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-selectiondag
Author: Matt Arsenault (arsenm)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/142532.diff
2 Files Affected:
- (modified) llvm/include/llvm/CodeGen/SelectionDAGISel.h (+1-1)
- (modified) llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp (+1-4)
``````````diff
diff --git a/llvm/include/llvm/CodeGen/SelectionDAGISel.h b/llvm/include/llvm/CodeGen/SelectionDAGISel.h
index 7a41e09b6aeaf..375d2f31e2835 100644
--- a/llvm/include/llvm/CodeGen/SelectionDAGISel.h
+++ b/llvm/include/llvm/CodeGen/SelectionDAGISel.h
@@ -47,7 +47,7 @@ class SelectionDAGISel {
TargetMachine &TM;
const TargetLibraryInfo *LibInfo;
std::unique_ptr<FunctionLoweringInfo> FuncInfo;
- SwiftErrorValueTracking *SwiftError;
+ std::unique_ptr<SwiftErrorValueTracking> SwiftError;
MachineFunction *MF;
MachineModuleInfo *MMI;
MachineRegisterInfo *RegInfo;
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
index 56ee4e98406b1..f599637564715 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
@@ -386,10 +386,7 @@ SelectionDAGISel::SelectionDAGISel(TargetMachine &tm, CodeGenOptLevel OL)
initializeTargetLibraryInfoWrapperPassPass(*PassRegistry::getPassRegistry());
}
-SelectionDAGISel::~SelectionDAGISel() {
- delete CurDAG;
- delete SwiftError;
-}
+SelectionDAGISel::~SelectionDAGISel() { delete CurDAG; }
void SelectionDAGISelLegacy::getAnalysisUsage(AnalysisUsage &AU) const {
CodeGenOptLevel OptLevel = Selector->OptLevel;
``````````
</details>
https://github.com/llvm/llvm-project/pull/142532
More information about the llvm-commits
mailing list