[llvm] SelectionDAG: Use unique_ptr for SwiftErrorValueTracking (PR #142532)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 2 22:56:15 PDT 2025


https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/142532

None

>From aa9ea69c56f466f779d0cd8c3e503e7ca11b692d Mon Sep 17 00:00:00 2001
From: Matt Arsenault <Matthew.Arsenault at amd.com>
Date: Mon, 2 Jun 2025 17:40:20 +0200
Subject: [PATCH] SelectionDAG: Use unique_ptr for SwiftErrorValueTracking

---
 llvm/include/llvm/CodeGen/SelectionDAGISel.h       | 2 +-
 llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp | 5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/llvm/include/llvm/CodeGen/SelectionDAGISel.h b/llvm/include/llvm/CodeGen/SelectionDAGISel.h
index 7a41e09b6aeaf..375d2f31e2835 100644
--- a/llvm/include/llvm/CodeGen/SelectionDAGISel.h
+++ b/llvm/include/llvm/CodeGen/SelectionDAGISel.h
@@ -47,7 +47,7 @@ class SelectionDAGISel {
   TargetMachine &TM;
   const TargetLibraryInfo *LibInfo;
   std::unique_ptr<FunctionLoweringInfo> FuncInfo;
-  SwiftErrorValueTracking *SwiftError;
+  std::unique_ptr<SwiftErrorValueTracking> SwiftError;
   MachineFunction *MF;
   MachineModuleInfo *MMI;
   MachineRegisterInfo *RegInfo;
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
index 56ee4e98406b1..f599637564715 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
@@ -386,10 +386,7 @@ SelectionDAGISel::SelectionDAGISel(TargetMachine &tm, CodeGenOptLevel OL)
   initializeTargetLibraryInfoWrapperPassPass(*PassRegistry::getPassRegistry());
 }
 
-SelectionDAGISel::~SelectionDAGISel() {
-  delete CurDAG;
-  delete SwiftError;
-}
+SelectionDAGISel::~SelectionDAGISel() { delete CurDAG; }
 
 void SelectionDAGISelLegacy::getAnalysisUsage(AnalysisUsage &AU) const {
   CodeGenOptLevel OptLevel = Selector->OptLevel;



More information about the llvm-commits mailing list