[llvm] [BOLT] Fix LLVM_APPEND_VC_REV support (PR #142410)
Paschalis Mpeis via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 2 07:57:17 PDT 2025
paschalis-mpeis wrote:
### Details regarding the NFC checks ([llvm-zorg](https://github.com/llvm/llvm-zorg/blob/main/zorg/buildbot/builders/BOLTBuilder.py#L105)):
One of the nfc-test issues is due to a BOLT SHA mismatch. The problem isn't actually in the `bolt_info` section. That section does not end up in the final `build/bin/llvm-bolt`, regardless of whether `LLVM_APPEND_VC_REV` is used. For example:
```bash
# section not present
$ llvm-objdump -s -j .note.bolt_info build/bin/llvm-bolt
llvm-objdump: warning: .. not found in any input file
```
However, there is a mismatch , in a `.rodata` [literal](https://github.com/llvm/llvm-project/blob/0289ca09bebe16c6e93dc13df6c293529fb1ee77/bolt/lib/Utils/CommandLineOpts.cpp#L20). This patch should fix it.
@aaupov, in the coming days I'll publish more patches, adjusting both bolt and llvm-zorg.
https://github.com/llvm/llvm-project/pull/142410
More information about the llvm-commits
mailing list