[llvm] expandFMINIMUMNUM_FMAXIMUMNUM: Quiet is not needed for NaN vs NaN (PR #139237)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 2 03:34:01 PDT 2025


================
@@ -8690,11 +8690,8 @@ SDValue TargetLowering::expandFMINIMUMNUM_FMAXIMUMNUM(SDNode *Node,
 
   SDValue MinMax =
       DAG.getSelectCC(DL, LHS, RHS, LHS, RHS, IsMax ? ISD::SETGT : ISD::SETLT);
-  // If MinMax is NaN, let's quiet it.
-  if (!Flags.hasNoNaNs() && !DAG.isKnownNeverNaN(LHS) &&
-      !DAG.isKnownNeverNaN(RHS)) {
-    MinMax = DAG.getNode(ISD::FCANONICALIZE, DL, VT, MinMax, Flags);
-  }
+
+  // TODO:We need quiet sNaN if strictfp.
----------------
nikic wrote:

```suggestion
  // TODO: We need quiet sNaN if strictfp.
```

https://github.com/llvm/llvm-project/pull/139237


More information about the llvm-commits mailing list