[llvm] [MemProf] Attach value profile metadata to the IR using CalleeGuids. (PR #141164)

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Sat May 31 06:59:52 PDT 2025


================
@@ -978,8 +978,9 @@ static void addVPMetadata(Module &M, Instruction &I,
 
   if (I.getMetadata(LLVMContext::MD_prof)) {
     uint64_t Unused;
-    auto ExistingVD =
-        getValueProfDataFromInst(I, IPVK_IndirectCallTarget, ~0U, Unused);
+    // ~0U means get all available value profile data without any count limit
----------------
teresajohnson wrote:

This seems like overkill, why do we need them all given that we quit below if it is non-empty? At least for now why not just set this to 1? For eventual merging, it could be increased to one of the max values for this call in ICP. If you change this add a TODO

https://github.com/llvm/llvm-project/pull/141164


More information about the llvm-commits mailing list