[compiler-rt] [Sanitizer] Fix android test env issue (PR #142235)
Ellis Hoag via llvm-commits
llvm-commits at lists.llvm.org
Fri May 30 16:14:15 PDT 2025
https://github.com/ellishg created https://github.com/llvm/llvm-project/pull/142235
I attempted to fix android tests in https://github.com/llvm/llvm-project/pull/142207 (broken by https://github.com/llvm/llvm-project/pull/141820). They are still failing but now I have more info.
https://lab.llvm.org/buildbot/#/builders/186/builds/9504/steps/16/logs/stdio
ERROR: Can't open file: //foo.8862 (reason: 30)
I believe the reason is that on android the HOME and TMPDIR environment variables are not being set correctly, or they are not read correctly. (https://github.com/llvm/llvm-project/pull/142234#issuecomment-2923694428)
Also remove an extra %env left in a related test.
>From 04c50977e9df64bcc07e33a5f2e80f172a342ca3 Mon Sep 17 00:00:00 2001
From: Ellis Hoag <ellis.sparky.hoag at gmail.com>
Date: Fri, 30 May 2025 16:13:06 -0700
Subject: [PATCH] [Sanitizer] fix android test env issue
---
.../TestCases/Posix/sanitizer_set_report_path_fail.cpp | 4 ++--
.../test/sanitizer_common/android_commands/android_run.py | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp
index 782cd0218fd22..af5187a0d3265 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp
@@ -1,10 +1,10 @@
// RUN: %clangxx -O2 %s -o %t
// Case 1: Try setting a path that is an invalid/inaccessible directory.
-// RUN: not %env %run %t 2>&1 | FileCheck %s --check-prefix=ERROR1
+// RUN: not %run %t 2>&1 | FileCheck %s --check-prefix=ERROR1
// Case 2: Try setting a path that is too large.
-// RUN: not %env %run %t A 2>&1 | FileCheck %s --check-prefix=ERROR2
+// RUN: not %run %t A 2>&1 | FileCheck %s --check-prefix=ERROR2
#include <sanitizer/common_interface_defs.h>
#include <stdio.h>
diff --git a/compiler-rt/test/sanitizer_common/android_commands/android_run.py b/compiler-rt/test/sanitizer_common/android_commands/android_run.py
index f50fc1eb2540d..3f41ce4447dcf 100755
--- a/compiler-rt/test/sanitizer_common/android_commands/android_run.py
+++ b/compiler-rt/test/sanitizer_common/android_commands/android_run.py
@@ -13,7 +13,7 @@ def build_env():
# Android linker ignores RPATH. Set LD_LIBRARY_PATH to Output dir.
args.append("LD_LIBRARY_PATH=%s" % (ANDROID_TMPDIR,))
for (key, value) in list(os.environ.items()):
- if key in ["ASAN_ACTIVATION_OPTIONS", "SCUDO_OPTIONS"] or key.endswith(
+ if key in ["ASAN_ACTIVATION_OPTIONS", "SCUDO_OPTIONS", "HOME", "TMPDIR"] or key.endswith(
"SAN_OPTIONS"
):
args.append('%s="%s"' % (key, value.replace('"', '\\"')))
More information about the llvm-commits
mailing list