[llvm] AMDGPU: Fix broken XFAILed test for fat pointer null initializers (PR #142015)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu May 29 22:53:06 PDT 2025


https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/142015

>From 752f01704b69d5fb51d778e7b896d343c35a70a8 Mon Sep 17 00:00:00 2001
From: Matt Arsenault <Matthew.Arsenault at amd.com>
Date: Thu, 29 May 2025 21:10:00 +0200
Subject: [PATCH] AMDGPU: Fix broken XFAILed test for fat pointer null
 initializers

This was failing on the buffer fat pointer lowering error in the
addrspace(7) case, not the expected asm printer breakage. Also remove
the attempt at FileChecking the result, since that is dependent on the
actual fix and we want the unexpected pass whenever the assert is fixed.
---
 llvm/test/CodeGen/AMDGPU/nullptr-long-address-spaces.ll | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/llvm/test/CodeGen/AMDGPU/nullptr-long-address-spaces.ll b/llvm/test/CodeGen/AMDGPU/nullptr-long-address-spaces.ll
index 6556f07c73504..e039225dba3e7 100644
--- a/llvm/test/CodeGen/AMDGPU/nullptr-long-address-spaces.ll
+++ b/llvm/test/CodeGen/AMDGPU/nullptr-long-address-spaces.ll
@@ -1,6 +1,6 @@
 ; XFAIL: *
-; RUN: llc < %s -mtriple=amdgcn-- -verify-machineinstrs | FileCheck -check-prefixes=CHECK,GCN %s
-; RUN: llc < %s -mtriple=r600-- -verify-machineinstrs | FileCheck -check-prefixes=CHECK,R600 %s
+; REQUIRES: asserts
+; RUN: llc -mtriple=amdgcn-- < %s
 
 ; This is a temporary xfail, as the assembly printer is broken when dealing with
 ; lowerConstant() trying to return a value of size greater than 8 bytes.
@@ -9,10 +9,10 @@
 ; The exact form of the GCN output depends on how the printer gets fixed.
 ; GCN-NEXT: .zeroes 5
 ; R600-NEXT: .long 0
- at nullptr7 = global ptr addrspace(7) addrspacecast (ptr null to ptr addrspace(7))
+; @nullptr7 = global ptr addrspace(7) addrspacecast (ptr null to ptr addrspace(7))
 
 ; CHECK-LABEL: nullptr8:
 ; The exact form of the GCN output depends on how the printer gets fixed.
 ; GCN-NEXT: .zeroes 4
 ; R600-NEXT: .long 0
- at nullptr8 = global ptr addrspace(8) addrspacecast (ptr null to ptr addrspace(7))
+ at nullptr8 = global ptr addrspace(8) addrspacecast (ptr null to ptr addrspace(8))



More information about the llvm-commits mailing list