[llvm] [utils][tests] Adjust timeout-hang.py tolerances (PR #142089)
Hubert Tong via llvm-commits
llvm-commits at lists.llvm.org
Thu May 29 22:48:20 PDT 2025
https://github.com/hubert-reinterpretcast created https://github.com/llvm/llvm-project/pull/142089
The subject test sporadically fails on the AIX builder: https://lab.llvm.org/buildbot/#/builders/64/builds/3921/steps/6/logs/FAIL__lit___timeout-hang_py
This appears to be an environment issue potentially connected to high load because the problem is not observed on other AIX machines.
This patch separates the "hard" timeout value from the value used to signal a hang. This allows for a more generous "hard" timeout value, which allows observation of cases that take longer to finish despite not hanging.
>From bb7970e40f226978fa54ffafc807f03b571fcdc2 Mon Sep 17 00:00:00 2001
From: Hubert Tong <hubert.reinterpretcast at gmail.com>
Date: Thu, 29 May 2025 23:41:18 -0400
Subject: [PATCH] [utils][tests] Adjust timeout-hang.py tolerances
The subject test sporadically fails on the AIX builder:
https://lab.llvm.org/buildbot/#/builders/64/builds/3921/steps/6/logs/FAIL__lit___timeout-hang_py
This appears to be an environment issue potentially connected to high
load because the problem is not observed on other AIX machines.
This patch separates the "hard" timeout value from the value used to
signal a hang. This allows for a more generous "hard" timeout value,
which allows observation of cases that take longer to finish despite not
hanging.
---
llvm/utils/lit/tests/timeout-hang.py | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/llvm/utils/lit/tests/timeout-hang.py b/llvm/utils/lit/tests/timeout-hang.py
index 486f07983708f..4c4bccd670f73 100644
--- a/llvm/utils/lit/tests/timeout-hang.py
+++ b/llvm/utils/lit/tests/timeout-hang.py
@@ -8,20 +8,21 @@
# throwing an exception. We expect this to fail immediately, rather than
# timeout.
-# DEFINE: %{timeout}=1
+# DEFINE: %{grace_period}=5
+# DEFINE: %{hard_timeout}=15
# RUN: not %{lit} %{inputs}/timeout-hang/run-nonexistent.txt \
-# RUN: --timeout=%{timeout} --param external=0 | %{python} %s %{timeout}
+# RUN: --timeout=%{hard_timeout} --param external=0 | %{python} %s %{grace_period}
import sys
import re
-timeout_time = float(sys.argv[1])
+grace_time = float(sys.argv[1])
testing_time = float(re.search(r"Testing Time: (.*)s", sys.stdin.read()).group(1))
-if testing_time < timeout_time:
- print("Testing took less than timeout")
+if testing_time <= grace_time:
+ print("Testing finished within the grace period")
sys.exit(0)
else:
- print("Testing took as long or longer than timeout")
+ print("Testing took {}s, which is beyond the grace period of {}s".format(testing_time, grace_time))
sys.exit(1)
More information about the llvm-commits
mailing list