[llvm] 8e2a42a - [X86] Return from SimplifyDemandedBitsForTargetNode for X86ISD::CMOV/ANDP after computing KnownBits. NFC (#141992)
via llvm-commits
llvm-commits at lists.llvm.org
Thu May 29 12:59:45 PDT 2025
Author: Craig Topper
Date: 2025-05-29T12:59:42-07:00
New Revision: 8e2a42aa921f11d14064a41b6fb28a0bad38af32
URL: https://github.com/llvm/llvm-project/commit/8e2a42aa921f11d14064a41b6fb28a0bad38af32
DIFF: https://github.com/llvm/llvm-project/commit/8e2a42aa921f11d14064a41b6fb28a0bad38af32.diff
LOG: [X86] Return from SimplifyDemandedBitsForTargetNode for X86ISD::CMOV/ANDP after computing KnownBits. NFC (#141992)
If we break out of the switch, I believe we fall back to the generic
SimplifyDemandedBitsForTargetNode which will call
computeKnownBitsForTargetNode. This will recurse again and calculate
it's own KnownBits. Since we already did the recursion, we should keep
the results.
Added:
Modified:
llvm/lib/Target/X86/X86ISelLowering.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 6b71f49165c60..ecadc86a0b781 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -44789,7 +44789,7 @@ bool X86TargetLowering::SimplifyDemandedBitsForTargetNode(
// Only known if known in both the LHS and RHS.
Known = Known.intersectWith(Known2);
- break;
+ return false;
}
case X86ISD::BEXTR:
case X86ISD::BEXTRI: {
More information about the llvm-commits
mailing list