[llvm] [MemProf] Summary section cleanup (NFC) (PR #142003)

Snehasish Kumar via llvm-commits llvm-commits at lists.llvm.org
Thu May 29 11:37:56 PDT 2025


================
@@ -314,15 +314,15 @@ Error writeMemProf(
     ProfOStream &OS, memprof::IndexedMemProfData &MemProfData,
     memprof::IndexedVersion MemProfVersionRequested, bool MemProfFullSchema,
     std::unique_ptr<memprof::DataAccessProfData> DataAccessProfileData,
-    memprof::MemProfSummary *MemProfSum) {
+    std::unique_ptr<memprof::MemProfSummary> MemProfSum) {
   switch (MemProfVersionRequested) {
   case memprof::Version2:
     return writeMemProfV2(OS, MemProfData, MemProfFullSchema);
   case memprof::Version3:
     return writeMemProfV3(OS, MemProfData, MemProfFullSchema);
   case memprof::Version4:
     return writeMemProfV4(OS, MemProfData, MemProfFullSchema,
-                          std::move(DataAccessProfileData), MemProfSum);
+                          std::move(DataAccessProfileData), MemProfSum.get());
----------------
snehasish wrote:

Can we move it into the v4 and update the interface there too like `DataAccessProfileData`?

https://github.com/llvm/llvm-project/pull/142003


More information about the llvm-commits mailing list