[llvm] [memprof] Improve a comment (NFC) (PR #142002)
via llvm-commits
llvm-commits at lists.llvm.org
Thu May 29 11:11:12 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-transforms
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
We can go one step further than "compare" and mention "prefix" to
succinctly describe the function.
---
Full diff: https://github.com/llvm/llvm-project/pull/142002.diff
1 Files Affected:
- (modified) llvm/lib/Transforms/Instrumentation/MemProfiler.cpp (+3-3)
``````````diff
diff --git a/llvm/lib/Transforms/Instrumentation/MemProfiler.cpp b/llvm/lib/Transforms/Instrumentation/MemProfiler.cpp
index deb9f8999eab7..c88feac16d7ac 100644
--- a/llvm/lib/Transforms/Instrumentation/MemProfiler.cpp
+++ b/llvm/lib/Transforms/Instrumentation/MemProfiler.cpp
@@ -762,9 +762,9 @@ static AllocationType addCallStack(CallStackTrie &AllocTrie,
return AllocType;
}
-// Helper to compare the InlinedCallStack computed from an instruction's debug
-// info to a list of Frames from profile data (either the allocation data or a
-// callsite).
+// Return true if InlinedCallStack, computed from a call instruction's debug
+// info, is a prefix of ProfileCallStack, a list of Frames from profile data
+// (either the allocation data or a callsite).
static bool
stackFrameIncludesInlinedCallStack(ArrayRef<Frame> ProfileCallStack,
ArrayRef<uint64_t> InlinedCallStack) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/142002
More information about the llvm-commits
mailing list