[flang] [llvm] [flang][OpenMP] Overhaul implementation of ATOMIC construct (PR #137852)

[Krzysztof Parzyszek via llvm-commits]

================
@@ -16,10 +16,18 @@
 #include "flang/Semantics/openmp-modifiers.h"
 #include "flang/Semantics/tools.h"
 #include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/StringSwitch.h"
 #include <variant>
 
 namespace Fortran::semantics {
 
+static_assert(std::is_same_v<SomeExpr, evaluate::Expr<evaluate::SomeType>>);
----------------
kparzysz wrote:

I deleted that.  `SomeExpr` is a typedef defined independently (but identically) in several places, and I wanted to make sure that we detect if the definition changes.  We don't need that check, if the definitions start to disagree it would cause lots of other issues.

https://github.com/llvm/llvm-project/pull/137852