[llvm] [GlobalISel] support lowering of G_SHUFFLEVECTOR with pointer args (PR #141959)

Stanley Gambarin via llvm-commits llvm-commits at lists.llvm.org
Thu May 29 08:00:44 PDT 2025


https://github.com/stanleygambarin created https://github.com/llvm/llvm-project/pull/141959

None

>From 4d055df3e9e6d7c8218aff0bc72a0bf226ec80b5 Mon Sep 17 00:00:00 2001
From: "Gambarin, Stanley" <stanley.gambarin at intel.com>
Date: Thu, 29 May 2025 07:45:34 -0700
Subject: [PATCH] [GlobalISel] support lowering of G_SHUFFLEVECTOR with pointer
 args

---
 .../CodeGen/GlobalISel/LegalizerHelper.cpp    |  6 +++---
 .../AMDGPU/shufflevector-pointer-crash.mir    | 21 +++++++++++++++++++
 2 files changed, 24 insertions(+), 3 deletions(-)
 create mode 100644 llvm/test/CodeGen/AMDGPU/shufflevector-pointer-crash.mir

diff --git a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
index 7b18a98d7f3ca..83ba71e4c9d49 100644
--- a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
@@ -8446,10 +8446,10 @@ LegalizerHelper::lowerShuffleVector(MachineInstr &MI) {
     }
   }
 
-  if (DstTy.isScalar())
-    MIRBuilder.buildCopy(DstReg, BuildVec[0]);
-  else
+  if (DstTy.isVector())
     MIRBuilder.buildBuildVector(DstReg, BuildVec);
+  else
+    MIRBuilder.buildCopy(DstReg, BuildVec[0]);
   MI.eraseFromParent();
   return Legalized;
 }
diff --git a/llvm/test/CodeGen/AMDGPU/shufflevector-pointer-crash.mir b/llvm/test/CodeGen/AMDGPU/shufflevector-pointer-crash.mir
new file mode 100644
index 0000000000000..03b870b923454
--- /dev/null
+++ b/llvm/test/CodeGen/AMDGPU/shufflevector-pointer-crash.mir
@@ -0,0 +1,21 @@
+# RUN: llc -march=amdgcn -run-pass=legalizer -verify-machineinstrs %s -o - 
+
+--- |
+  define i32 @test(i64 %arg) {
+    ret i32 0
+  }
+...
+name:            test
+tracksRegLiveness: true
+body: |
+  bb.0:
+    %9:_(p0) = G_CONSTANT i64 0
+    %10:_(<2 x p0>) = G_BUILD_VECTOR %9:_(p0), %9:_(p0)
+    %8:_(<2 x p0>) = G_LOAD %9:_(p0) :: (load (<2 x p0>) from `ptr null`, align 64)
+    %11:_(p0) = G_SHUFFLE_VECTOR %8:_(<2 x p0>), %10:_, shufflemask(0)
+    %12:_(s32), %13:_(s32) = G_UNMERGE_VALUES %11:_(p0)
+    $vgpr0 = COPY %12:_(s32)
+    $vgpr1 = COPY %13:_(s32)
+    SI_RETURN implicit $vgpr0, implicit $vgpr1
+...
+



More information about the llvm-commits mailing list