[llvm] [Analysis] Use the addCost() helper across InlineCost.cpp (PR #141901)
via llvm-commits
llvm-commits at lists.llvm.org
Wed May 28 23:23:22 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-analysis
Author: Gleb Popov (arrowd)
<details>
<summary>Changes</summary>
for consistency sake.
---
Full diff: https://github.com/llvm/llvm-project/pull/141901.diff
1 Files Affected:
- (modified) llvm/lib/Analysis/InlineCost.cpp (+7-7)
``````````diff
diff --git a/llvm/lib/Analysis/InlineCost.cpp b/llvm/lib/Analysis/InlineCost.cpp
index 8ddfa1e4eb6f7..55525be9b6f22 100644
--- a/llvm/lib/Analysis/InlineCost.cpp
+++ b/llvm/lib/Analysis/InlineCost.cpp
@@ -717,7 +717,7 @@ class InlineCostCallAnalyzer final : public CallAnalyzer {
if (CA.analyze().isSuccess()) {
// We were able to inline the indirect call! Subtract the cost from the
// threshold to get the bonus we want to apply, but don't go below zero.
- Cost -= std::max(0, CA.getThreshold() - CA.getCost());
+ addCost(-std::max(0, CA.getThreshold() - CA.getCost()));
}
} else
// Otherwise simply add the cost for merely making the call.
@@ -1116,7 +1116,7 @@ class InlineCostCallAnalyzer final : public CallAnalyzer {
// If this function uses the coldcc calling convention, prefer not to inline
// it.
if (F.getCallingConv() == CallingConv::Cold)
- Cost += InlineConstants::ColdccPenalty;
+ addCost(InlineConstants::ColdccPenalty);
LLVM_DEBUG(dbgs() << " Initial cost: " << Cost << "\n");
@@ -2126,7 +2126,7 @@ void InlineCostCallAnalyzer::updateThreshold(CallBase &Call, Function &Callee) {
// the cost of inlining it drops dramatically. It may seem odd to update
// Cost in updateThreshold, but the bonus depends on the logic in this method.
if (isSoleCallToLocalFunction(Call, F)) {
- Cost -= LastCallToStaticBonus;
+ addCost(-LastCallToStaticBonus);
StaticBonusApplied = LastCallToStaticBonus;
}
}
@@ -3040,16 +3040,16 @@ int llvm::getCallsiteCost(const TargetTransformInfo &TTI, const CallBase &Call,
// DataLayout.
NumStores = std::min(NumStores, 8U);
- Cost += 2 * NumStores * InstrCost;
+ addCost(2 * NumStores * InstrCost);
} else {
// For non-byval arguments subtract off one instruction per call
// argument.
- Cost += InstrCost;
+ addCost(InstrCost);
}
}
// The call instruction also disappears after inlining.
- Cost += InstrCost;
- Cost += TTI.getInlineCallPenalty(Call.getCaller(), Call, CallPenalty);
+ addCost(InstrCost);
+ addCost(TTI.getInlineCallPenalty(Call.getCaller(), Call, CallPenalty));
return std::min<int64_t>(Cost, INT_MAX);
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/141901
More information about the llvm-commits
mailing list