[llvm] [Github] Fix TODO after removal of continue on error (PR #141896)

[Aiden Grossman via llvm-commits]

https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/141896

Previously we were using continue-on-error within the workflows to prevent sending out notifications for workflow failures. We worked around this in the metrics container to see what was actually failing/passing by looking at the individual steps. Now that we have gotten rid of the continue-on-error flag, we just have to look at the job status.

>From 7fcff190dc5187e2581e5fe746ac9ef94c15ded5 Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Thu, 29 May 2025 04:53:22 +0000
Subject: [PATCH] [Github] Fix TODO after removal of continue on error

Previously we were using continue-on-error within the workflows to
prevent sending out notifications for workflow failures. We worked
around this in the metrics container to see what was actually
failing/passing by looking at the individual steps. Now that we have
gotten rid of the continue-on-error flag, we just have to look at the
job status.
---
 .ci/metrics/metrics.py | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/.ci/metrics/metrics.py b/.ci/metrics/metrics.py
index 40d192c6def23..171bc20a95710 100644
--- a/.ci/metrics/metrics.py
+++ b/.ci/metrics/metrics.py
@@ -349,19 +349,7 @@ def github_get_metrics(
                     running_count[metric_name] += 1
                 continue
 
-            job_result = int(job.conclusion == "success")
-            if job_result:
-                # We still might want to mark the job as a failure if one of the steps
-                # failed. This is required due to use setting continue-on-error in
-                # the premerge pipeline to prevent sending emails while we are
-                # testing the infrastructure.
-                # TODO(boomanaiden154): Remove this once the premerge pipeline is no
-                # longer in a testing state and we can directly assert the workflow
-                # result.
-                for step in job.steps:
-                    if step.conclusion != "success" and step.conclusion != "skipped":
-                        job_result = 0
-                        break
+            job_result = int(job.conclusion == "success" or job.conclusion == "skipped")
 
             created_at = job.created_at
             started_at = job.started_at