[llvm] [BOLT] Gadget scanner: detect authentication oracles (PR #135663)

[Kristof Beyls via llvm-commits]

================
@@ -717,6 +740,457 @@ SrcSafetyAnalysis::create(BinaryFunction &BF,
                                                        RegsToTrackInstsFor);
 }
 
+/// A state representing which registers are safe to be used as the destination
+/// operand of an authentication instruction.
+///
+/// Similar to SrcState, it is the responsibility of the analysis to take
+/// register aliasing into account.
+///
+/// Depending on the implementation, it may be possible that an authentication
----------------
kbeyls wrote:

"Depending on the implementation".
I'm wondering if it'd be easier for a reader if the documentation more explicitly states "AArch64 CPU" rather than "implementation".
When I started reading this comment, when I saw the word "implementation", I first thought there were e.g. going to be subclasses of this class, each with it's own implementation of an algorithm.

https://github.com/llvm/llvm-project/pull/135663