[llvm] [NFCI]Print LineLocation using its print method to simplify the code. (PR #141545)

Mingming Liu via llvm-commits llvm-commits at lists.llvm.org
Mon May 26 23:05:14 PDT 2025


https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/141545

>From d8d56ff8281b4d0c5d75cdb0d997d9c812f802aa Mon Sep 17 00:00:00 2001
From: mingmingl <mingmingl at google.com>
Date: Mon, 26 May 2025 22:56:51 -0700
Subject: [PATCH 1/2] [NFCI]Print LineLocation using its print method to
 simplify the code.

---
 llvm/lib/ProfileData/SampleProfWriter.cpp | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/llvm/lib/ProfileData/SampleProfWriter.cpp b/llvm/lib/ProfileData/SampleProfWriter.cpp
index 6fc16d9effdd6..28807e97b9482 100644
--- a/llvm/lib/ProfileData/SampleProfWriter.cpp
+++ b/llvm/lib/ProfileData/SampleProfWriter.cpp
@@ -580,12 +580,8 @@ std::error_code SampleProfileWriterText::writeSample(const FunctionSamples &S) {
     LineLocation Loc = I->first;
     const SampleRecord &Sample = I->second;
     OS.indent(Indent + 1);
-    if (Loc.Discriminator == 0)
-      OS << Loc.LineOffset << ": ";
-    else
-      OS << Loc.LineOffset << "." << Loc.Discriminator << ": ";
-
-    OS << Sample.getSamples();
+    Loc.print(OS);
+    OS << ": " << Sample.getSamples();
 
     for (const auto &J : Sample.getSortedCallTargets())
       OS << " " << J.first << ":" << J.second;

>From 4ab367a5d03660fe5e41115d2c8fa6f5edcc8132 Mon Sep 17 00:00:00 2001
From: mingmingl <mingmingl at google.com>
Date: Mon, 26 May 2025 23:04:47 -0700
Subject: [PATCH 2/2] fix another loc

---
 llvm/lib/ProfileData/SampleProfWriter.cpp | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/llvm/lib/ProfileData/SampleProfWriter.cpp b/llvm/lib/ProfileData/SampleProfWriter.cpp
index 28807e97b9482..8b164f24e06e1 100644
--- a/llvm/lib/ProfileData/SampleProfWriter.cpp
+++ b/llvm/lib/ProfileData/SampleProfWriter.cpp
@@ -597,10 +597,8 @@ std::error_code SampleProfileWriterText::writeSample(const FunctionSamples &S) {
       LineLocation Loc = I->first;
       const FunctionSamples &CalleeSamples = FS.second;
       OS.indent(Indent);
-      if (Loc.Discriminator == 0)
-        OS << Loc.LineOffset << ": ";
-      else
-        OS << Loc.LineOffset << "." << Loc.Discriminator << ": ";
+      Loc.print(OS);
+      OS << ": ";
       if (std::error_code EC = writeSample(CalleeSamples))
         return EC;
     }



More information about the llvm-commits mailing list