[llvm] 88ee42a - MCSymbol: Remove the default argument of getFragment

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Mon May 26 21:18:23 PDT 2025


Author: Fangrui Song
Date: 2025-05-26T21:18:17-07:00
New Revision: 88ee42af6b4a5e94f054fcc034eb627c7b0f27cf

URL: https://github.com/llvm/llvm-project/commit/88ee42af6b4a5e94f054fcc034eb627c7b0f27cf
DIFF: https://github.com/llvm/llvm-project/commit/88ee42af6b4a5e94f054fcc034eb627c7b0f27cf.diff

LOG: MCSymbol: Remove the default argument of getFragment

Follow-up to ca5b3a0f51baa6fddef4d888bf0aacca89e6f565
("[MC] Remove SetUsed on isUndefined and getFragment").

The upcoming change will allow .set to reassign non-absolute values,
removing `IsUsed`.

Added: 
    

Modified: 
    llvm/include/llvm/MC/MCSymbol.h
    llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/MC/MCSymbol.h b/llvm/include/llvm/MC/MCSymbol.h
index 627c92ec77f91..3885ce0bff37f 100644
--- a/llvm/include/llvm/MC/MCSymbol.h
+++ b/llvm/include/llvm/MC/MCSymbol.h
@@ -258,7 +258,7 @@ class MCSymbol {
   /// isInSection - Check if this symbol is defined in some section (i.e., it
   /// is defined but not absolute).
   bool isInSection() const {
-    auto *F = getFragment(0);
+    auto *F = getFragment();
     return F && F != AbsolutePseudoFragment;
   }
 
@@ -399,12 +399,12 @@ class MCSymbol {
     return SymbolContents == SymContentsTargetCommon;
   }
 
-  MCFragment *getFragment(bool SetUsed = false) const {
+  MCFragment *getFragment() const {
     if (Fragment || !isVariable() || isWeakExternal())
       return Fragment;
     // If the symbol is a non-weak alias, get information about
     // the aliasee. (Don't try to resolve weak aliases.)
-    Fragment = getVariableValue(SetUsed)->findAssociatedFragment();
+    Fragment = getVariableValue(false)->findAssociatedFragment();
     return Fragment;
   }
 

diff  --git a/llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
index d4015c351af11..43d643035fa5c 100644
--- a/llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
+++ b/llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
@@ -878,7 +878,7 @@ void X86AsmBackend::finishLayout(MCAssembler const &Asm) const {
   // disabled by default to eliminate the -g vs non -g 
diff erence.
   DenseSet<MCFragment *> LabeledFragments;
   for (const MCSymbol &S : Asm.symbols())
-    LabeledFragments.insert(S.getFragment(false));
+    LabeledFragments.insert(S.getFragment());
 
   for (MCSection &Sec : Asm) {
     if (!Sec.isText())


        


More information about the llvm-commits mailing list