[llvm] 714096c - [LLVM] Skip dumping inline SDag children (#141359)

via llvm-commits llvm-commits at lists.llvm.org
Mon May 26 19:40:04 PDT 2025


Author: Jon Roelofs
Date: 2025-05-26T19:40:01-07:00
New Revision: 714096c132662715d05af9a892b4d9552673a644

URL: https://github.com/llvm/llvm-project/commit/714096c132662715d05af9a892b4d9552673a644
DIFF: https://github.com/llvm/llvm-project/commit/714096c132662715d05af9a892b4d9552673a644.diff

LOG: [LLVM] Skip dumping inline SDag children (#141359)

If they're simple enough to render inline, we don't need to dump them
again in the recursive walk.

Added: 
    

Modified: 
    llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
    llvm/test/CodeGen/PowerPC/ppc64-icbt-pwr7.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
index ee4297f3ad8ce..61c6a9470e531 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
@@ -1165,6 +1165,9 @@ static void printrWithDepthHelper(raw_ostream &OS, const SDNode *N,
     // Don't follow chain operands.
     if (Op.getValueType() == MVT::Other)
       continue;
+    // Don't print children that were fully rendered inline.
+    if (shouldPrintInline(*Op.getNode(), G))
+      continue;
     OS << '\n';
     printrWithDepthHelper(OS, Op.getNode(), G, depth - 1, indent + 2);
   }

diff  --git a/llvm/test/CodeGen/PowerPC/ppc64-icbt-pwr7.ll b/llvm/test/CodeGen/PowerPC/ppc64-icbt-pwr7.ll
index c9de1d8fc4334..c84eb8509ba56 100644
--- a/llvm/test/CodeGen/PowerPC/ppc64-icbt-pwr7.ll
+++ b/llvm/test/CodeGen/PowerPC/ppc64-icbt-pwr7.ll
@@ -11,9 +11,6 @@ entry:
 
 ; FIXME: Crashing is not really the correct behavior here, we really should just emit nothing
 ; CHECK: Cannot select: {{0x[0-9,a-f]+|t[0-9]+}}: ch = Prefetch
-; CHECK: {{0x[0-9,a-f]+|t[0-9]+}}: i32 = TargetConstant<0>
-; CHECK-NEXT: {{0x[0-9,a-f]+|t[0-9]+}}: i32 = TargetConstant<3>
-; CHECK-NEXT: {{0x[0-9,a-f]+|t[0-9]+}}: i32 = TargetConstant<0>
 
 }
 


        


More information about the llvm-commits mailing list