[llvm] [llvm] Use std::tie to Implment operator< (NFC) (PR #139391)
via llvm-commits
llvm-commits at lists.llvm.org
Sat May 10 09:54:25 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-hexagon
@llvm/pr-subscribers-llvm-support
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/139391.diff
2 Files Affected:
- (modified) llvm/include/llvm/Support/InstructionCost.h (+2-3)
- (modified) llvm/lib/Target/Hexagon/HexagonConstExtenders.cpp (+1-5)
``````````diff
diff --git a/llvm/include/llvm/Support/InstructionCost.h b/llvm/include/llvm/Support/InstructionCost.h
index d5f7457e04748..8e8aa6cfd717b 100644
--- a/llvm/include/llvm/Support/InstructionCost.h
+++ b/llvm/include/llvm/Support/InstructionCost.h
@@ -20,6 +20,7 @@
#include "llvm/Support/MathExtras.h"
#include <limits>
+#include <tuple>
namespace llvm {
@@ -191,9 +192,7 @@ class InstructionCost {
/// the states are valid and users can test for validity of the cost
/// explicitly.
bool operator<(const InstructionCost &RHS) const {
- if (State != RHS.State)
- return State < RHS.State;
- return Value < RHS.Value;
+ return std::tie(State, Value) < std::tie(RHS.State, RHS.Value);
}
bool operator==(const InstructionCost &RHS) const {
diff --git a/llvm/lib/Target/Hexagon/HexagonConstExtenders.cpp b/llvm/lib/Target/Hexagon/HexagonConstExtenders.cpp
index bc51b293b5dda..f38e7b879e5f0 100644
--- a/llvm/lib/Target/Hexagon/HexagonConstExtenders.cpp
+++ b/llvm/lib/Target/Hexagon/HexagonConstExtenders.cpp
@@ -107,11 +107,7 @@ namespace {
return !operator==(R);
}
bool operator<(const OffsetRange &R) const {
- if (Min != R.Min)
- return Min < R.Min;
- if (Max != R.Max)
- return Max < R.Max;
- return Align < R.Align;
+ return std::tie(Min, Max, Align) < std::tie(R.Min, R.Max, R.Align);
}
static OffsetRange zero() { return {0, 0, 1}; }
};
``````````
</details>
https://github.com/llvm/llvm-project/pull/139391
More information about the llvm-commits
mailing list