[llvm] [BOLT] Support profile density with basic samples (PR #137644)

Amir Ayupov via llvm-commits llvm-commits at lists.llvm.org
Fri May 9 16:53:00 PDT 2025


aaupov wrote:

> > > members that used to have "branch" in the name now use "sample" which means "sample or branch", which makes "sample" ambiguous.
> > 
> > 
> > "Sample" is supposed to cover different profile types. We disambiguate it by adding "basic" or "branch" to it. So I'd say this change generalizes stats that were only applicable to branch samples to cover basic samples as well. Do you agree?
> 
> In general, outside of context of `DataAggregator`, I agree. But in the code, we refer to non-LBR samples as just samples.

Good that we have shared understanding. In that case, I'd rather make DataAggregator usage of "sample" consistent with it, specifying "basic" where necessary, not introduce another term for samples just to avoid collisions.

Let me keep RawBranchCount here and do the renaming in a separate NFC diff.

https://github.com/llvm/llvm-project/pull/137644


More information about the llvm-commits mailing list