[llvm] 5f4dc9b - Fix build failure in DXILResource.h on newer versions of MSVC (#139309)
via llvm-commits
llvm-commits at lists.llvm.org
Fri May 9 16:40:18 PDT 2025
Author: Daniel Paoliello
Date: 2025-05-09T16:40:14-07:00
New Revision: 5f4dc9b924e69319b1308053518b5fab33397b69
URL: https://github.com/llvm/llvm-project/commit/5f4dc9b924e69319b1308053518b5fab33397b69
DIFF: https://github.com/llvm/llvm-project/commit/5f4dc9b924e69319b1308053518b5fab33397b69.diff
LOG: Fix build failure in DXILResource.h on newer versions of MSVC (#139309)
The change #137258 introduced a build break on newer versions of MSVC:
```
llvm\include\llvm\Analysis\DXILResource.h(674) : warning C4715: 'llvm::DXILResourceBindingInfo::getBindingSpaces': not all control paths return a value
```
Fix is to add a `default` case that will ICE.
Added:
Modified:
llvm/include/llvm/Analysis/DXILResource.h
Removed:
################################################################################
diff --git a/llvm/include/llvm/Analysis/DXILResource.h b/llvm/include/llvm/Analysis/DXILResource.h
index d819ead34bc9f..ec41188ff0848 100644
--- a/llvm/include/llvm/Analysis/DXILResource.h
+++ b/llvm/include/llvm/Analysis/DXILResource.h
@@ -691,6 +691,8 @@ class DXILResourceBindingInfo {
case dxil::ResourceClass::Sampler:
return SamplerSpaces;
}
+
+ llvm_unreachable("Invalid resource class");
}
friend class DXILResourceBindingAnalysis;
More information about the llvm-commits
mailing list