[llvm] [ARM] Enable verifyInstructionPredicates (PR #139262)
David Green via llvm-commits
llvm-commits at lists.llvm.org
Fri May 9 06:06:41 PDT 2025
https://github.com/davemgreen created https://github.com/llvm/llvm-project/pull/139262
All the tests pass and a bootstrap and run of the llvm-test-suite passed successfully. Enable verifyInstructionPredicates so that instructions which are invalid with the current set of features produces an error.
>From fad19b074f328c475860bbb150e5fe5a88446402 Mon Sep 17 00:00:00 2001
From: David Green <david.green at arm.com>
Date: Fri, 9 May 2025 13:58:20 +0100
Subject: [PATCH] [ARM] Enable verifyInstructionPredicates
All the tests pass and a bootstrap and run of the llvm-test-suite passed
successfully. Enable verifyInstructionPredicates so that instructions which are
invalid with the current set of features produces an error.
---
llvm/lib/Target/ARM/ARMAsmPrinter.cpp | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/llvm/lib/Target/ARM/ARMAsmPrinter.cpp b/llvm/lib/Target/ARM/ARMAsmPrinter.cpp
index b71a1faa0d520..2505a67727aad 100644
--- a/llvm/lib/Target/ARM/ARMAsmPrinter.cpp
+++ b/llvm/lib/Target/ARM/ARMAsmPrinter.cpp
@@ -1442,9 +1442,8 @@ void ARMAsmPrinter::EmitUnwindingInstruction(const MachineInstr *MI) {
#include "ARMGenMCPseudoLowering.inc"
void ARMAsmPrinter::emitInstruction(const MachineInstr *MI) {
- // TODOD FIXME: Enable feature predicate checks once all the test pass.
- // ARM_MC::verifyInstructionPredicates(MI->getOpcode(),
- // getSubtargetInfo().getFeatureBits());
+ ARM_MC::verifyInstructionPredicates(MI->getOpcode(),
+ getSubtargetInfo().getFeatureBits());
const DataLayout &DL = getDataLayout();
MCTargetStreamer &TS = *OutStreamer->getTargetStreamer();
More information about the llvm-commits
mailing list