[llvm] [SCEV] Improve code in SCEVLoopGuardRewriter (NFC) (PR #139257)
via llvm-commits
llvm-commits at lists.llvm.org
Fri May 9 05:57:11 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-analysis
Author: Ramkumar Ramachandra (artagnon)
<details>
<summary>Changes</summary>
Prefer DenseMap::lookup over DenseMap::find.
---
Full diff: https://github.com/llvm/llvm-project/pull/139257.diff
1 Files Affected:
- (modified) llvm/lib/Analysis/ScalarEvolution.cpp (+12-12)
``````````diff
diff --git a/llvm/lib/Analysis/ScalarEvolution.cpp b/llvm/lib/Analysis/ScalarEvolution.cpp
index 3f9614254ae7a..38071c0714e82 100644
--- a/llvm/lib/Analysis/ScalarEvolution.cpp
+++ b/llvm/lib/Analysis/ScalarEvolution.cpp
@@ -15867,8 +15867,8 @@ const SCEV *ScalarEvolution::LoopGuards::rewrite(const SCEV *Expr) const {
}
const SCEV *visitZeroExtendExpr(const SCEVZeroExtendExpr *Expr) {
- auto I = Map.find(Expr);
- if (I == Map.end()) {
+ const SCEV *S = Map.lookup(Expr);
+ if (!S) {
// If we didn't find the extact ZExt expr in the map, check if there's
// an entry for a smaller ZExt we can use instead.
Type *Ty = Expr->getType();
@@ -15887,29 +15887,29 @@ const SCEV *ScalarEvolution::LoopGuards::rewrite(const SCEV *Expr) const {
return SCEVRewriteVisitor<SCEVLoopGuardRewriter>::visitZeroExtendExpr(
Expr);
}
- return I->second;
+ return S;
}
const SCEV *visitSignExtendExpr(const SCEVSignExtendExpr *Expr) {
- auto I = Map.find(Expr);
- if (I == Map.end())
+ const SCEV *S = Map.lookup(Expr);
+ if (!S)
return SCEVRewriteVisitor<SCEVLoopGuardRewriter>::visitSignExtendExpr(
Expr);
- return I->second;
+ return S;
}
const SCEV *visitUMinExpr(const SCEVUMinExpr *Expr) {
- auto I = Map.find(Expr);
- if (I == Map.end())
+ const SCEV *S = Map.lookup(Expr);
+ if (!S)
return SCEVRewriteVisitor<SCEVLoopGuardRewriter>::visitUMinExpr(Expr);
- return I->second;
+ return S;
}
const SCEV *visitSMinExpr(const SCEVSMinExpr *Expr) {
- auto I = Map.find(Expr);
- if (I == Map.end())
+ const SCEV *S = Map.lookup(Expr);
+ if (!S)
return SCEVRewriteVisitor<SCEVLoopGuardRewriter>::visitSMinExpr(Expr);
- return I->second;
+ return S;
}
const SCEV *visitAddExpr(const SCEVAddExpr *Expr) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/139257
More information about the llvm-commits
mailing list