[llvm] [DirectX] Implement DXILResourceBindingAnalysis (PR #137258)

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Thu May 8 16:49:03 PDT 2025


================
@@ -879,8 +883,122 @@ SmallVector<dxil::ResourceInfo *> DXILResourceMap::findByUse(const Value *Key) {
 
 //===----------------------------------------------------------------------===//
 
+void DXILResourceBindingInfo::populate(Module &M, DXILResourceTypeMap &DRTM) {
+  struct Binding {
+    ResourceClass ResClass;
+    uint32_t Space;
+    uint32_t LowerBound;
+    uint32_t UpperBound;
+    Binding(ResourceClass RC, uint32_t Sp, uint32_t LB, uint32_t UB)
+        : ResClass(RC), Space(Sp), LowerBound(LB), UpperBound(UB) {}
----------------
bogner wrote:

Better to just shadow the member names rather than make the parameters unreadable.
```suggestion
    Binding(ResourceClass RC, uint32_t Space, uint32_t LowerBound, uint32_t UpperBound)
        : ResClass(RC), Space(Space), LowerBound(LowerBound), UpperBound(UpperBound) {}
```

https://github.com/llvm/llvm-project/pull/137258


More information about the llvm-commits mailing list