[llvm] [DirectX] Adding support for Root Descriptors in obj2yaml/yaml2obj (PR #137259)

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Thu May 8 16:02:54 PDT 2025


================
@@ -121,16 +121,19 @@ namespace DirectX {
 struct RootParameterView {
   const dxbc::RootParameterHeader &Header;
   StringRef ParamData;
-  RootParameterView(const dxbc::RootParameterHeader &H, StringRef P)
+  RootParameterView(uint32_t V, const dxbc::RootParameterHeader &H, StringRef P)
----------------
bogner wrote:

`Version` still seems to be unused, but now it's an unused member instead of just an unused parameter. Please simply remove it if it isn't needed. Also, if we were to need it, `V` is a bad name for the argument.

https://github.com/llvm/llvm-project/pull/137259


More information about the llvm-commits mailing list