[llvm] [llvm-objdump] Add support for HIP offload bundles (PR #114834)

Thu May 8 15:03:54 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-sles-build-only` running on `rocm-worker-hw-04-sles` while building `llvm` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/140/builds/22781

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (compile-openmp) failure: build (failure)
...
6.747 [3803/32/3342] Building CXX object tools/mlir/lib/Interfaces/CMakeFiles/obj.MLIRLoopLikeInterface.dir/LoopLikeInterface.cpp.o
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/mlir/lib/Interfaces/LoopLikeInterface.cpp: In static member function ‘static bool mlir::LoopLikeOpInterface::blockIsInLoop(mlir::Block*)’:
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/mlir/lib/Interfaces/LoopLikeInterface.cpp:41:23: warning: unused variable ‘it’ [-Wunused-variable]
     auto [it, inserted] = visited.insert(current);
                       ^
At global scope:
cc1plus: warning: unrecognized command line option ‘-Wno-deprecated-copy’
cc1plus: warning: unrecognized command line option ‘-Wno-unnecessary-virtual-specifier’
6.750 [3802/32/3343] Building CXX object tools/mlir/lib/Interfaces/CMakeFiles/obj.MLIRDataLayoutInterfaces.dir/DataLayoutInterfaces.cpp.o
6.754 [3801/32/3344] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/OffloadBundle.cpp.o
FAILED: lib/Object/CMakeFiles/LLVMObject.dir/OffloadBundle.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Object -I/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Object -Iinclude -I/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-noexcept-type -Wno-unnecessary-virtual-specifier -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++1z -MD -MT lib/Object/CMakeFiles/LLVMObject.dir/OffloadBundle.cpp.o -MF lib/Object/CMakeFiles/LLVMObject.dir/OffloadBundle.cpp.o.d -o lib/Object/CMakeFiles/LLVMObject.dir/OffloadBundle.cpp.o -c /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Object/OffloadBundle.cpp
In file included from /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Object/OffloadBundle.cpp:9:0:
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/include/llvm/Object/OffloadBundle.h: In static member function ‘static llvm::Expected<std::unique_ptr<llvm::object::OffloadBundleURI> > llvm::object::OffloadBundleURI::createFileURI(llvm::StringRef)’:
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/include/llvm/Object/OffloadBundle.h:182:12: error: could not convert ‘OffloadingURI’ from ‘std::unique_ptr<llvm::object::OffloadBundleURI>’ to ‘llvm::Expected<std::unique_ptr<llvm::object::OffloadBundleURI> >’
     return OffloadingURI;
            ^~~~~~~~~~~~~
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Object/OffloadBundle.cpp: In function ‘llvm::Error llvm::object::extractOffloadBundleFatBinary(const llvm::object::ObjectFile&, llvm::SmallVectorImpl<llvm::object::OffloadBundleFatBin>&)’:
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Object/OffloadBundle.cpp:181:31: warning: unused variable ‘CoffSection’ [-Wunused-variable]
           const coff_section *CoffSection = COFFObj->getCOFFSection(Sec);
                               ^~~~~~~~~~~
At global scope:
cc1plus: warning: unrecognized command line option ‘-Wno-unnecessary-virtual-specifier’
6.758 [3801/31/3345] Building CXX object tools/mlir/lib/Interfaces/CMakeFiles/obj.MLIRCopyOpInterface.dir/CopyOpInterface.cpp.o
6.758 [3801/30/3346] Building CXX object tools/mlir/lib/Interfaces/CMakeFiles/obj.MLIRDestinationStyleOpInterface.dir/DestinationStyleOpInterface.cpp.o
6.759 [3801/29/3347] Building CXX object tools/mlir/lib/Interfaces/CMakeFiles/obj.MLIRShapedOpInterfaces.dir/ShapedOpInterfaces.cpp.o
6.761 [3801/28/3348] Building CXX object tools/mlir/lib/Interfaces/CMakeFiles/obj.MLIRDerivedAttributeOpInterface.dir/DerivedAttributeOpInterface.cpp.o
6.763 [3801/27/3349] Building CXX object tools/mlir/lib/Query/Matcher/CMakeFiles/obj.MLIRQueryMatcher.dir/Diagnostics.cpp.o
6.764 [3801/26/3350] Building CXX object tools/mlir/lib/Interfaces/CMakeFiles/obj.MLIRParallelCombiningOpInterface.dir/ParallelCombiningOpInterface.cpp.o
6.765 [3801/25/3351] Building CXX object tools/mlir/lib/Interfaces/CMakeFiles/obj.MLIRMemorySlotInterfaces.dir/MemorySlotInterfaces.cpp.o
6.765 [3801/24/3352] Building CXX object tools/mlir/lib/Query/Matcher/CMakeFiles/obj.MLIRQueryMatcher.dir/ErrorBuilder.cpp.o
6.765 [3801/23/3353] Building CXX object tools/mlir/lib/Interfaces/CMakeFiles/obj.MLIRInferTypeOpInterface.dir/InferTypeOpInterface.cpp.o
6.766 [3801/22/3354] Building CXX object tools/mlir/lib/Query/Matcher/CMakeFiles/obj.MLIRQueryMatcher.dir/RegistryManager.cpp.o
6.766 [3801/21/3355] Building CXX object tools/mlir/lib/Query/Matcher/CMakeFiles/obj.MLIRQueryMatcher.dir/Parser.cpp.o
6.766 [3801/20/3356] Building CXX object tools/mlir/lib/Query/Matcher/CMakeFiles/obj.MLIRQueryMatcher.dir/VariantValue.cpp.o
8.836 [3801/19/3357] Building CXX object lib/MC/MCParser/CMakeFiles/LLVMMCParser.dir/AsmParser.cpp.o
9.345 [3801/18/3358] Building AMDGPUGenMCPseudoLowering.inc...
9.619 [3801/17/3359] Building AMDGPUGenPostLegalizeGICombiner.inc...
10.260 [3801/16/3360] Building AMDGPUGenRegBankGICombiner.inc...
10.394 [3801/15/3361] Building AMDGPUGenSubtargetInfo.inc...
10.399 [3801/14/3362] Building AMDGPUGenDisassemblerTables.inc...
10.454 [3801/13/3363] Building AMDGPUGenPreLegalizeGICombiner.inc...
10.867 [3801/12/3364] Building AMDGPUGenMCCodeEmitter.inc...
11.166 [3801/11/3365] Building AMDGPUGenCallingConv.inc...
12.592 [3801/10/3366] Building AMDGPUGenAsmWriter.inc...
13.041 [3801/9/3367] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
13.633 [3801/8/3368] Building AMDGPUGenAsmMatcher.inc...
13.798 [3801/7/3369] Building AMDGPUGenGlobalISel.inc...
13.996 [3801/6/3370] Building AMDGPUGenDAGISel.inc...

```

</details>

https://github.com/llvm/llvm-project/pull/114834