[llvm] 92d9492 - [RISCV] Address post-commit review feedback on 1ac489c8e

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Thu May 8 14:31:21 PDT 2025


Author: Philip Reames
Date: 2025-05-08T14:30:54-07:00
New Revision: 92d949229273a7c1dfb923a2b8fbac92fae04fd5

URL: https://github.com/llvm/llvm-project/commit/92d949229273a7c1dfb923a2b8fbac92fae04fd5
DIFF: https://github.com/llvm/llvm-project/commit/92d949229273a7c1dfb923a2b8fbac92fae04fd5.diff

LOG: [RISCV] Address post-commit review feedback on 1ac489c8e

As noted by @s-barannikov, the last argument wasn't reflected in the type
profile for the SDNode, nor was it being used by the patterns.

Added: 
    

Modified: 
    llvm/lib/Target/RISCV/RISCVISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index d65e921dfc660..9c7aedf5acaf2 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -18054,10 +18054,8 @@ static SDValue lowerVQDOT(unsigned Opc, SDValue Op0, SDValue Op1,
   Op1 = convertToScalableVector(ContainerVT, Op1, DAG, Subtarget);
 
   auto [Mask, VL] = getDefaultVLOps(VT, ContainerVT, DL, DAG, Subtarget);
-  const unsigned Policy = RISCVVType::TAIL_AGNOSTIC | RISCVVType::MASK_AGNOSTIC;
-  SDValue PolicyOp = DAG.getTargetConstant(Policy, DL, Subtarget.getXLenVT());
   SDValue LocalAccum = DAG.getNode(Opc, DL, ContainerVT,
-                                   {Op0, Op1, Passthru, Mask, VL, PolicyOp});
+                                   {Op0, Op1, Passthru, Mask, VL});
   return convertFromScalableVector(VT, LocalAccum, DAG, Subtarget);
 }
 


        


More information about the llvm-commits mailing list