https://github.com/nikic commented: This looks ok, but I think the naming needs more consideration. I think the general intention is to use the same names as PatternMatch but with an m_scev prefix, so I left suggestions accordingly. https://github.com/llvm/llvm-project/pull/138836