[llvm] [MemProf] Avoid assertion checking loop under NDEBUG (NFC) (PR #138985)

[Teresa Johnson via llvm-commits]

================
@@ -5242,6 +5242,7 @@ bool MemProfContextDisambiguation::applyImport(Module &M) {
           assert(AI != FS->allocs().end());
           auto &AllocNode = *(AI++);
 
+#ifndef NDEBUG
           // Sanity check that the MIB stack ids match between the summary and
           // instruction metadata.
           auto MIBIter = AllocNode.MIBs.begin();
----------------
teresajohnson wrote:

Done. There were a couple of other live in variables. I also updated one of the methods to take a const to enable using const for the new helper.

https://github.com/llvm/llvm-project/pull/138985