[llvm] [MemProf] Avoid assertion checking loop under NDEBUG (NFC) (PR #138985)
Snehasish Kumar via llvm-commits
llvm-commits at lists.llvm.org
Wed May 7 16:35:56 PDT 2025
================
@@ -5242,6 +5242,7 @@ bool MemProfContextDisambiguation::applyImport(Module &M) {
assert(AI != FS->allocs().end());
auto &AllocNode = *(AI++);
+#ifndef NDEBUG
// Sanity check that the MIB stack ids match between the summary and
// instruction metadata.
auto MIBIter = AllocNode.MIBs.begin();
----------------
snehasish wrote:
<!--__GRAPHITE_HTML_TAG_START__--><p class='graphite__hidden'><i>[Re: line +5251]</i></p><!--__GRAPHITE_HTML_TAG_END__-->
I think we can drop this attribute now that it's guarded by the ifdef?
<!--__GRAPHITE_HTML_TAG_START__--><p class='graphite__hidden'>See this comment inline on <a href="https://app.graphite.dev/github/pr/llvm/llvm-project/138985?utm_source=unchanged-line-comment">Graphite</a>.</p><!--__GRAPHITE_HTML_TAG_END__-->
https://github.com/llvm/llvm-project/pull/138985
More information about the llvm-commits
mailing list