[llvm] [VPlan] Retain exit conditions and edges in initial VPlan (NFC). (PR #137709)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Wed May 7 01:56:14 PDT 2025


fhahn wrote:

> Commit message needs updating (and completion..)
> 

Thanks, updated now.

> TODO: Suspect `mergeBlocksIntoPredecessors()` might lose predecessor positions as it doesn't check if the empty block's successors have a single predecessor (though that may be the case currently; otherwise should probably not be considered atm). Supplying `removeOnEdge(Block)` which disconnects Block from its single Pred and single Succ, reconnecting them together while retaining pred and succ positions may help, but an empty block being merged into its predecessor may have multiple successors - rather than being on an edge.

Now there's no need to remove/merge, so I left the TODO out of the commit message for now. It will mangle the predecessor order of the successors, at the moment not used in places where successors could have phi-like recipes I think

https://github.com/llvm/llvm-project/pull/137709


More information about the llvm-commits mailing list