[lld] dd3f6a3 - [lld] Remove redundant calls to std::unique_ptr<T>::get (NFC) (#138641)

via llvm-commits llvm-commits at lists.llvm.org
Tue May 6 07:55:36 PDT 2025


Author: Kazu Hirata
Date: 2025-05-06T07:55:33-07:00
New Revision: dd3f6a3d3edf4b950e38aee20d2efb0af0f423cf

URL: https://github.com/llvm/llvm-project/commit/dd3f6a3d3edf4b950e38aee20d2efb0af0f423cf
DIFF: https://github.com/llvm/llvm-project/commit/dd3f6a3d3edf4b950e38aee20d2efb0af0f423cf.diff

LOG: [lld] Remove redundant calls to std::unique_ptr<T>::get (NFC) (#138641)

Added: 
    

Modified: 
    lld/COFF/DriverUtils.cpp

Removed: 
    


################################################################################
diff  --git a/lld/COFF/DriverUtils.cpp b/lld/COFF/DriverUtils.cpp
index 664d1747e9cbd..b6334406035ac 100644
--- a/lld/COFF/DriverUtils.cpp
+++ b/lld/COFF/DriverUtils.cpp
@@ -417,7 +417,7 @@ LinkerDriver::createManifestXmlWithInternalMt(StringRef defaultXml) {
       MemoryBuffer::getMemBufferCopy(defaultXml);
 
   windows_manifest::WindowsManifestMerger merger;
-  if (auto e = merger.merge(*defaultXmlCopy.get()))
+  if (auto e = merger.merge(*defaultXmlCopy))
     Fatal(ctx) << "internal manifest tool failed on default xml: "
                << toString(std::move(e));
 
@@ -430,7 +430,7 @@ LinkerDriver::createManifestXmlWithInternalMt(StringRef defaultXml) {
                  << toString(std::move(e));
   }
 
-  return std::string(merger.getMergedManifest().get()->getBuffer());
+  return std::string(merger.getMergedManifest()->getBuffer());
 }
 
 std::string


        


More information about the llvm-commits mailing list