[llvm] [VPlan] Retain exit conditions and edges in initial VPlan (NFC). (PR #137709)

via llvm-commits llvm-commits at lists.llvm.org
Tue May 6 07:46:57 PDT 2025


================
@@ -146,14 +149,6 @@ bool PlainCFGBuilder::isExternalDef(Value *Val) {
     // Instruction definition is in outermost loop PH.
     return false;
 
-  // Check whether Instruction definition is in a loop exit.
-  SmallVector<BasicBlock *> ExitBlocks;
-  TheLoop->getExitBlocks(ExitBlocks);
-  if (is_contained(ExitBlocks, InstParent)) {
-    // Instruction definition is in outermost loop exit.
-    return false;
-  }
-
----------------
ayalz wrote:

Is this simply redundant, independently, as such instructions which reside in ExitBlocks are not contained in TheLoop?

Should the above definition of external defs be updated?

https://github.com/llvm/llvm-project/pull/137709


More information about the llvm-commits mailing list