[lld] [lld] Remove redundant calls to std::unique_ptr<T>::get (NFC) (PR #138641)
via llvm-commits
llvm-commits at lists.llvm.org
Tue May 6 00:07:01 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-platform-windows
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/138641.diff
1 Files Affected:
- (modified) lld/COFF/DriverUtils.cpp (+2-2)
``````````diff
diff --git a/lld/COFF/DriverUtils.cpp b/lld/COFF/DriverUtils.cpp
index 664d1747e9cbd..b6334406035ac 100644
--- a/lld/COFF/DriverUtils.cpp
+++ b/lld/COFF/DriverUtils.cpp
@@ -417,7 +417,7 @@ LinkerDriver::createManifestXmlWithInternalMt(StringRef defaultXml) {
MemoryBuffer::getMemBufferCopy(defaultXml);
windows_manifest::WindowsManifestMerger merger;
- if (auto e = merger.merge(*defaultXmlCopy.get()))
+ if (auto e = merger.merge(*defaultXmlCopy))
Fatal(ctx) << "internal manifest tool failed on default xml: "
<< toString(std::move(e));
@@ -430,7 +430,7 @@ LinkerDriver::createManifestXmlWithInternalMt(StringRef defaultXml) {
<< toString(std::move(e));
}
- return std::string(merger.getMergedManifest().get()->getBuffer());
+ return std::string(merger.getMergedManifest()->getBuffer());
}
std::string
``````````
</details>
https://github.com/llvm/llvm-project/pull/138641
More information about the llvm-commits
mailing list