[llvm] [PAC][MC][AArch64] Fix error message for AUTH_ABS64 reloc with ILP32 (PR #89563)

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Mon May 5 18:28:20 PDT 2025


================
@@ -211,18 +211,18 @@ unsigned AArch64ELFObjectWriter::getRelocType(MCContext &Ctx,
               Target.getAccessVariant() == MCSymbolRefExpr::VK_GOTPCREL)
                  ? ELF::R_AARCH64_GOTPCREL32
                  : R_CLS(ABS32);
-    case FK_Data_8:
+    case FK_Data_8: {
+      bool IsAuth = (RefKind == AArch64MCExpr::VK_AUTH ||
+                     RefKind == AArch64MCExpr::VK_AUTHADDR);
       if (IsILP32) {
         Ctx.reportError(Fixup.getLoc(),
-                        "ILP32 8 byte absolute data "
-                        "relocation not supported (LP64 eqv: ABS64)");
+                        Twine("ILP32 8 byte absolute data "
----------------
pcc wrote:

Also, I think we should get rid of these `LP64 eqv:` messages because of the maintenance burden and because they're not really helpful. If you're targeting ILP32 and writing assembly that triggers one of these messages then you're probably an expert who doesn't need help figuring out which relocation type to use, and knowing the LP64 equivalent wouldn't help you anyway because you'd need something that works on ILP32.

https://github.com/llvm/llvm-project/pull/89563


More information about the llvm-commits mailing list