[llvm] 15c2f79 - [DSE/GVN] Continue to improve memset.pattern testing [nfc]

[Philip Reames via llvm-commits]

Author: Philip Reames
Date: 2025-05-05T09:25:23-07:00
New Revision: 15c2f79153abe3dcee60aaeefe68946b1e93a1ed

URL: https://github.com/llvm/llvm-project/commit/15c2f79153abe3dcee60aaeefe68946b1e93a1ed
DIFF: https://github.com/llvm/llvm-project/commit/15c2f79153abe3dcee60aaeefe68946b1e93a1ed.diff

LOG: [DSE/GVN] Continue to improve memset.pattern testing [nfc]

This batch reveals two missed optimizations, but only one of which
is regression as compared to the memset_patternN libcall family.

Added: 
    llvm/test/Transforms/GVN/memset-pattern.ll

Modified: 
    llvm/test/Transforms/DeadStoreElimination/memset-and-memcpy.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/DeadStoreElimination/memset-and-memcpy.ll b/llvm/test/Transforms/DeadStoreElimination/memset-and-memcpy.ll
index 98b662ec85161..64ec54aa6cfd0 100644
--- a/llvm/test/Transforms/DeadStoreElimination/memset-and-memcpy.ll
+++ b/llvm/test/Transforms/DeadStoreElimination/memset-and-memcpy.ll
@@ -150,5 +150,29 @@ define void @memset_pattern_value_noalias(ptr %P, ptr noalias %Q) nounwind ssp {
   ret void
 }
 
+define void @memset_pattern_value_noalias2(ptr %P) nounwind ssp {;
+; CHECK-LABEL: @memset_pattern_value_noalias2(
+; CHECK-NEXT:    tail call void @llvm.experimental.memset.pattern.p0.p0.i64(ptr [[P:%.*]], ptr [[P]], i64 8, i1 false)
+; CHECK-NEXT:    tail call void @llvm.memset.p0.i64(ptr [[P]], i8 42, i64 200, i1 false)
+; CHECK-NEXT:    ret void
+;
+  tail call void @llvm.experimental.memset.pattern.p0.i64(ptr %P, ptr %P, i64 8, i1 false)
+  tail call void @llvm.memset.p0.i64(ptr %P, i8 42, i64 200, i1 false)
+  ret void
+}
+
+define void @memset_pattern_value_noalias3(ptr %P) nounwind ssp {
+; CHECK-LABEL: @memset_pattern_value_noalias3(
+; CHECK-NEXT:    [[Q:%.*]] = getelementptr i8, ptr [[P:%.*]], i32 8
+; CHECK-NEXT:    tail call void @llvm.experimental.memset.pattern.p0.p0.i64(ptr [[Q]], ptr [[P]], i64 8, i1 false)
+; CHECK-NEXT:    tail call void @llvm.memset.p0.i64(ptr [[Q]], i8 42, i64 200, i1 false)
+; CHECK-NEXT:    ret void
+;
+  %q = getelementptr i8, ptr %P, i32 8
+  tail call void @llvm.experimental.memset.pattern.p0.i64(ptr %q, ptr %P, i64 8, i1 false)
+  tail call void @llvm.memset.p0.i64(ptr %q, i8 42, i64 200, i1 false)
+  ret void
+}
+
 
 declare void @llvm.memcpy.inline.p0.p0.i64(ptr noalias nocapture writeonly, ptr noalias nocapture readonly, i64 immarg, i1 immarg)

diff  --git a/llvm/test/Transforms/GVN/memset-pattern.ll b/llvm/test/Transforms/GVN/memset-pattern.ll
new file mode 100644
index 0000000000000..20ac87e916757
--- /dev/null
+++ b/llvm/test/Transforms/GVN/memset-pattern.ll
@@ -0,0 +1,63 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -S < %s -passes=gvn | FileCheck %s
+
+; Analyze Load from clobbering memset.pattern.
+define i32 @memset_pattern_clobber_load(ptr %p) {
+; CHECK-LABEL: @memset_pattern_clobber_load(
+; CHECK-NEXT:    call void @llvm.experimental.memset.pattern.p0.i8.i64(ptr [[P:%.*]], i8 1, i64 8, i1 false)
+; CHECK-NEXT:    [[LOAD:%.*]] = load i32, ptr [[P]], align 4
+; CHECK-NEXT:    ret i32 [[LOAD]]
+;
+  call void @llvm.experimental.memset.pattern.p0.p0.i64(ptr %p, i8 1, i64 8, i1 false)
+  %load = load i32, ptr %p
+  ret i32 %load
+}
+
+define i32 @memset_pattern_clobber_load2(ptr %p) {
+; CHECK-LABEL: @memset_pattern_clobber_load2(
+; CHECK-NEXT:    call void @llvm.experimental.memset.pattern.p0.i16.i64(ptr [[P:%.*]], i16 1, i64 8, i1 false)
+; CHECK-NEXT:    [[LOAD:%.*]] = load i32, ptr [[P]], align 4
+; CHECK-NEXT:    ret i32 [[LOAD]]
+;
+  call void @llvm.experimental.memset.pattern(ptr %p, i16 1, i64 8, i1 false)
+  %load = load i32, ptr %p
+  ret i32 %load
+}
+
+define ptr @memset_pattern_clobber_load3(ptr %p) {
+; CHECK-LABEL: @memset_pattern_clobber_load3(
+; CHECK-NEXT:    call void @llvm.experimental.memset.pattern.p0.p0.i64(ptr [[P:%.*]], ptr [[P]], i64 8, i1 false)
+; CHECK-NEXT:    [[LOAD:%.*]] = load ptr, ptr [[P]], align 8
+; CHECK-NEXT:    ret ptr [[LOAD]]
+;
+  call void @llvm.experimental.memset.pattern(ptr %p, ptr %p, i64 8, i1 false)
+  %load = load ptr, ptr %p
+  ret ptr %load
+}
+
+define i32 @load_forward_over_memset_pattern(ptr %P, ptr noalias %Q) {
+; CHECK-LABEL: @load_forward_over_memset_pattern(
+; CHECK-NEXT:    tail call void @llvm.experimental.memset.pattern.p0.i8.i64(ptr [[P:%.*]], i8 27, i64 8, i1 false)
+; CHECK-NEXT:    ret i32 0
+;
+  %v1 = load i32, ptr %Q
+  tail call void @llvm.experimental.memset.pattern(ptr %P, i8 27, i64 8, i1 false)
+  %v2 = load i32, ptr %Q
+  %sub = sub i32 %v1, %v2
+  ret i32 %sub
+}
+
+define i32 @load_forward_over_memset_pattern2(ptr %P, ptr noalias %Q) nounwind ssp {
+; CHECK-LABEL: @load_forward_over_memset_pattern2(
+; CHECK-NEXT:    [[V1:%.*]] = load i32, ptr [[Q:%.*]], align 4
+; CHECK-NEXT:    tail call void @llvm.experimental.memset.pattern.p0.p0.i64(ptr [[P:%.*]], ptr [[Q]], i64 8, i1 false)
+; CHECK-NEXT:    [[V2:%.*]] = load i32, ptr [[Q]], align 4
+; CHECK-NEXT:    [[SUB:%.*]] = sub i32 [[V1]], [[V2]]
+; CHECK-NEXT:    ret i32 [[SUB]]
+;
+  %v1 = load i32, ptr %Q
+  tail call void @llvm.experimental.memset.pattern(ptr %P, ptr %Q, i64 8, i1 false)
+  %v2 = load i32, ptr %Q
+  %sub = sub i32 %v1, %v2
+  ret i32 %sub
+}