[llvm] [Linker] Update `linkInModule()` comment following change from `bool OverrideSymbols` to `unsigned Flags` (PR #138531)

Boaz Brickner via llvm-commits llvm-commits at lists.llvm.org
Mon May 5 06:34:41 PDT 2025


https://github.com/bricknerb created https://github.com/llvm/llvm-project/pull/138531

Original change: https://github.com/llvm/llvm-project/commit/020d4fb17f92410117bc858f586fead7c5088696

>From 1f13fb80c9dab608662d2140981aab112e11c5cd Mon Sep 17 00:00:00 2001
From: Boaz Brickner <brickner at google.com>
Date: Mon, 5 May 2025 15:33:58 +0200
Subject: [PATCH] [Linker] Update `linkInModule()` comment following change
 from `bool OverrideSymbols` to `unsigned Flags` Original change:
 https://github.com/llvm/llvm-project/commit/020d4fb17f92410117bc858f586fead7c5088696

---
 llvm/include/llvm/Linker/Linker.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/llvm/include/llvm/Linker/Linker.h b/llvm/include/llvm/Linker/Linker.h
index ac8041d8df1af..f8bc2837b413a 100644
--- a/llvm/include/llvm/Linker/Linker.h
+++ b/llvm/include/llvm/Linker/Linker.h
@@ -25,6 +25,7 @@ class Linker {
 public:
   enum Flags {
     None = 0,
+    /// Have symbols from Src shadow those in the Dest.
     OverrideFromSrc = (1 << 0),
     LinkOnlyNeeded = (1 << 1),
   };
@@ -33,9 +34,6 @@ class Linker {
 
   /// Link \p Src into the composite.
   ///
-  /// Passing OverrideSymbols as true will have symbols from Src
-  /// shadow those in the Dest.
-  ///
   /// Passing InternalizeCallback will have the linker call the function with
   /// the new module and a list of global value names to be internalized by the
   /// callback.



More information about the llvm-commits mailing list