[llvm] [PartiallyInlineLibCalls] Emit missed- and passed-optimization remarks when partially inlining sqrt (PR #123966)
    Matt Arsenault via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon May  5 06:03:25 PDT 2025
    
    
  
================
@@ -56,6 +56,20 @@ static bool optimizeSQRT(CallInst *Call, Function *CalledFunc,
   // dst = phi(v0, v1)
   //
 
+  ORE->emit([&]() {
+    return OptimizationRemark(DEBUG_TYPE, "SqrtPartiallyInlined",
+                              Call->getDebugLoc(), &CurrBB)
+           << "Partially inlined call to sqrt function despite having to use "
+              "errno for error handling: target has fast sqrt instruction";
----------------
arsenm wrote:
This doesn't know if the target has a "fast sqrt instruction" and this shouldn't be considering it 
https://github.com/llvm/llvm-project/pull/123966
    
    
More information about the llvm-commits
mailing list