[llvm] [AMDGPU] Remove implicit definition of register group when restoring the last sub-register after a spill (PR #133986)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon May 5 05:44:18 PDT 2025


================
@@ -1928,7 +1928,9 @@ void SIRegisterInfo::buildSpillLoadStore(
       MIB->setAsmPrinterFlag(MachineInstr::ReloadReuse);
     }
 
-    if (NeedSuperRegImpOperand && (IsFirstSubReg || IsLastSubReg))
+    bool IsSrcDstDef = SrcDstRegState & RegState::Define;
+    if (NeedSuperRegImpOperand &&
+        (IsFirstSubReg || (IsLastSubReg && !IsSrcDstDef)))
----------------
arsenm wrote:

Not sure what the second condition is doing here, why isn't this just IsFirstSubReg && isDef? 

https://github.com/llvm/llvm-project/pull/133986


More information about the llvm-commits mailing list