[llvm] [AMDGPU] Use Reg32Types for move-immediate patterns (PR #138422)
via llvm-commits
llvm-commits at lists.llvm.org
Sat May 3 13:09:25 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: Jay Foad (jayfoad)
<details>
<summary>Changes</summary>
This just avoids having another copy of the list of valid 32-bit pointer
types.
---
Full diff: https://github.com/llvm/llvm-project/pull/138422.diff
1 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/SIInstructions.td (+11-9)
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/SIInstructions.td b/llvm/lib/Target/AMDGPU/SIInstructions.td
index f5c6d47369781..dea20e2d84d7b 100644
--- a/llvm/lib/Target/AMDGPU/SIInstructions.td
+++ b/llvm/lib/Target/AMDGPU/SIInstructions.td
@@ -2270,16 +2270,18 @@ def : GCNPat <
// FIXME: Remove VGPRImm. Should be inferrable from register bank.
-foreach vt = [i32, p3, p5, p6, p2] in {
- def : GCNPat <
- (VGPRImm<(vt imm)>:$imm),
- (V_MOV_B32_e32 imm:$imm)
- >;
+foreach vt = Reg32Types.types in {
+ if !and(!not(vt.isVector), !not(vt.isFP)) then {
+ def : GCNPat <
+ (VGPRImm<(vt imm)>:$imm),
+ (V_MOV_B32_e32 imm:$imm)
+ >;
- def : GCNPat <
- (vt imm:$imm),
- (S_MOV_B32 imm:$imm)
- >;
+ def : GCNPat <
+ (vt imm:$imm),
+ (S_MOV_B32 imm:$imm)
+ >;
+ }
}
// FIXME: The register bank of the frame index should depend on the
``````````
</details>
https://github.com/llvm/llvm-project/pull/138422
More information about the llvm-commits
mailing list